Cherry-pick #2927 to gazebo11: Lens flare cleanup and colorization #2954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iche033
reviewed
Mar 31, 2021
|
I pushed a fix for the ogre_log test in a0aafa6 |
I don't see any other CI problems |
iche033
approved these changes
Apr 1, 2021
* Added color setting to LensFlare and LensFlareSensorPlugin. Added methods to expose scale and color to derived plugins. * Removed unused animated lens flare effect. * Removed noise_rgba.png, which is no longer used. * Changed a value in the lens flare shader back to its original 1.0. This means there will be no compensation for the removal of the legacy animation effect and the lens flares will look less intense.
* Add debugging output to ogre_log test * ogre_log test: ignore GLX extension line Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
force-pushed
the
pick_lens_flare_color_11
branch
from
a0aafa6
to
e3fa011
Compare
scpeters
added a commit
to scpeters/gazebo
that referenced
this pull request
Apr 14, 2021
* Add debugging output to ogre_log test * ogre_log test: ignore GLX extension line Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to scpeters/gazebo
that referenced
this pull request
Apr 16, 2021
* Add debugging output to ogre_log test * ogre_log test: ignore GLX extension line Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
that referenced
this pull request
Apr 21, 2021
* Add debugging output to ogre_log test * ogre_log test: ignore GLX extension line Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick forward of #2927 from gazebo9 to gazebo11. Use "rebase and merge".
Added methods to expose scale and color to derived plugins.
This means there will be no compensation for the removal of the
legacy animation effect and the lens flares will look less intense.