Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service for configuring view control sensitivity #504

Merged
merged 4 commits into from Nov 17, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Nov 17, 2022

馃帀 New feature

Closes gazebosim/gz-sim#1027

Related PR: gazebosim/gz-sim#1799

Summary

Exposes a service for controlling how sensitive the camera view control movements are. Default is 1.0. The higher the number the more sensitive camera view control is to mouse movements. Affects all camera movements - pan, orbit, zoom.

Note that I also updated the camera reference visual service name to include the view_control string to be consistent with other service names.

Test it

Use the spin box added in gazebosim/gz-sim#1799 to change the sensitivity settings and see the effect on camera movements.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #504 (c3c8b81) into ign-gui6 (cdbd53c) will decrease coverage by 0.60%.
The diff coverage is 22.00%.

@@             Coverage Diff              @@
##           ign-gui6     #504      +/-   ##
============================================
- Coverage     67.46%   66.85%   -0.61%     
============================================
  Files            39       39              
  Lines          5286     5310      +24     
============================================
- Hits           3566     3550      -16     
- Misses         1720     1760      +40     
Impacted Files Coverage 螖
src/plugins/minimal_scene/MinimalScene.cc 60.00% <15.38%> (-4.65%) 猬囷笍
...interactive_view_control/InteractiveViewControl.cc 18.04% <24.32%> (+2.15%) 猬嗭笍
src/plugins/scene3d/Scene3D.cc 49.87% <0.00%> (+0.25%) 猬嗭笍

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Core development automation moved this from Inbox to In review Nov 17, 2022
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, left a minor nit on dox

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@jennuine jennuine merged commit 0e4a198 into ign-gui6 Nov 17, 2022
@jennuine jennuine deleted the view_control_sensitivity branch November 17, 2022 22:45
Core development automation moved this from In review to Done Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃彲 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants