Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data race issues in CameraTracking plugin #537

Merged
merged 2 commits into from Apr 21, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 18, 2023

🦟 Bug fix

Summary

There are three threads at work here: the main thread, the render thread, and the transport thread. The change is meant to synchronize all of these threads.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from jennuine as a code owner April 18, 2023 22:33
@osrf-triage osrf-triage added this to Inbox in Core development Apr 18, 2023
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Apr 18, 2023
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #537 (2ed3fd8) into ign-gui6 (b3903b0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 2ed3fd8 differs from pull request most recent head 310fb68. Consider uploading reports for the commit 310fb68 to get more accurate results

@@             Coverage Diff              @@
##           ign-gui6     #537      +/-   ##
============================================
+ Coverage     69.83%   69.85%   +0.01%     
============================================
  Files            40       40              
  Lines          5324     5324              
============================================
+ Hits           3718     3719       +1     
+ Misses         1606     1605       -1     
Impacted Files Coverage Δ
src/plugins/camera_tracking/CameraTracking.cc 69.04% <100.00%> (+0.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Core development automation moved this from Inbox to In review Apr 20, 2023
@azeey azeey merged commit bd683eb into gazebosim:ign-gui6 Apr 21, 2023
8 of 9 checks passed
Core development automation moved this from In review to Done Apr 21, 2023
@azeey azeey deleted the fix_data_race_camera_tracking branch April 21, 2023 22:30
@azeey azeey mentioned this pull request Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants