-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified cmake target name for Ruby interfaces #285
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #285 +/- ##
=============================================
+ Coverage 99.41% 99.65% +0.23%
=============================================
Files 67 67
Lines 6374 6359 -15
=============================================
Hits 6337 6337
+ Misses 37 22 -15
Continue to review full report at Codecov.
|
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
Signed-off-by: ahcorde ahcorde@gmail.com
🦟 Bug fix
this PR blocks this other PR https://github.com/ignitionrobotics/ign-math/pull/280/files
pybind11 requires to call the target with the same name of the exported module. We would like to use
import gazebo.math
with Python interfaces. We are using this target name for the Ruby SWIG modules, SWIG allows to set some variable to call the module with the desired name.This is just a change of the target name should not affect behaviour.
Summary
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge