Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cone shape from particle emitter #446

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Remove Cone shape from particle emitter #446

merged 1 commit into from
Jun 17, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 17, 2024

🦟 Bug fix

Summary

Similar to gazebosim/sdformat#1434, let's only add cone shape to particle emitters when there is support for it.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested a review from caguero as a code owner June 17, 2024 17:29
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.33%. Comparing base (3eae409) to head (5084179).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
+ Coverage   98.19%   98.33%   +0.13%     
==========================================
  Files          27       27              
  Lines        1166     1202      +36     
==========================================
+ Hits         1145     1182      +37     
+ Misses         21       20       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iche033 iche033 mentioned this pull request Jun 17, 2024
8 tasks
@iche033 iche033 merged commit 3d18b1e into main Jun 17, 2024
12 checks passed
@iche033 iche033 deleted the particle_cone branch June 17, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants