Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MJCF to SDF: Added gravity, wind and magnetic field #56

Merged
merged 3 commits into from
May 31, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented May 31, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Added gravity, wind and magnetic field

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from azeey May 31, 2022 08:22
@ahcorde ahcorde self-assigned this May 31, 2022
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #56 (a39bdc3) into main (d559811) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   97.79%   97.83%   +0.03%     
==========================================
  Files          16       16              
  Lines         636      646      +10     
==========================================
+ Hits          622      632      +10     
  Misses         14       14              
Impacted Files Coverage Δ
...f_to_sdformat/mjcf_to_sdformat/converters/world.py 97.22% <100.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d559811...a39bdc3. Read the comment docs.

@ahcorde ahcorde mentioned this pull request May 31, 2022
9 tasks
@ahcorde ahcorde changed the title Added gravity, wind and magnetic field MJCF to SDF: Added gravity, wind and magnetic field May 31, 2022
@ahcorde ahcorde merged commit 60f2d21 into main May 31, 2022
@ahcorde ahcorde deleted the ahcorde/mjcf2sdf/option_gravity branch May 31, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants