Workaround on warnings for Ubuntu Noble (#995)

* Add pragma ignores for Woverloaded-virtual
* Ignore the warning on FindCUDA removal

---------

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>

CMakeLists.txt

@@ -171,6 +171,11 @@ set(GZ_RENDERING_ENGINE_INSTALL_DIR
 if(NOT MSVC)
   #--------------------------------------
   # Find CUDA
+  # Module is being removed in CMake and needs a non trivial
+  # migration https://cmake.org/cmake/help/latest/policy/CMP0146.html
+  if(POLICY CMP0146)
+    cmake_policy(SET CMP0146 OLD)
+  endif()
   find_package(CUDA)
 
   #--------------------------------------

include/gz/rendering/Camera.hh

@@ -28,6 +28,13 @@
 #include "gz/rendering/Sensor.hh"
 #include "gz/rendering/Scene.hh"
 
+// overloaded-virtuals warnings appeared on Ubuntu Noble
+// GCC-13. it is not easy to fix them without breaking ABI
+// ignore them to preserve current ABI.
+#if defined(__GNUC__) || defined(__clang__)
+# pragma GCC diagnostic push
+# pragma GCC diagnostic ignored "-Woverloaded-virtual"
+#endif
 
 namespace gz
 {
@@ -369,4 +376,9 @@ namespace gz
     }
   }
 }
+
+#if defined(__GNUC__) || defined(__clang__)
+# pragma GCC diagnostic pop
+#endif
+
 #endif

include/gz/rendering/Object.hh

@@ -22,6 +22,14 @@
 #include "gz/rendering/RenderTypes.hh"
 #include "gz/rendering/Export.hh"
 
+// overloaded-virtuals warnings appeared on Ubuntu Noble
+// GCC-13. it is not easy to fix them without breaking ABI
+// ignore them to preserve current ABI.
+#if defined(__GNUC__) || defined(__clang__)
+# pragma GCC diagnostic push
+# pragma GCC diagnostic ignored "-Woverloaded-virtual"
+#endif
+
 namespace gz
 {
   namespace rendering
@@ -69,4 +77,9 @@ namespace gz
     }
   }
 }
+
+#if defined(__GNUC__) || defined(__clang__)
+# pragma GCC diagnostic pop
+#endif
+
 #endif

include/gz/rendering/Visual.hh

@@ -22,6 +22,14 @@
 #include "gz/rendering/config.hh"
 #include "gz/rendering/Node.hh"
 
+// overloaded-virtuals warnings appeared on Ubuntu Noble
+// GCC-13. it is not easy to fix them without breaking ABI
+// ignore them to preserve current ABI.
+#if defined(__GNUC__) || defined(__clang__)
+# pragma GCC diagnostic push
+# pragma GCC diagnostic ignored "-Woverloaded-virtual"
+#endif
+
 namespace gz
 {
   namespace rendering
@@ -206,4 +214,9 @@ namespace gz
     }
   }
 }
+
+#if defined(__GNUC__) || defined(__clang__)
+# pragma GCC diagnostic pop
+#endif
+
 #endif

include/gz/rendering/base/BaseRenderTarget.hh

@@ -25,6 +25,14 @@
 #include "gz/rendering/Scene.hh"
 #include "gz/rendering/base/BaseRenderTypes.hh"
 
+// overloaded-virtuals warnings appeared on Ubuntu Noble
+// GCC-13. it is not easy to fix them without breaking ABI
+// ignore them to preserve current ABI.
+#if defined(__GNUC__) || defined(__clang__)
+# pragma GCC diagnostic push
+# pragma GCC diagnostic ignored "-Woverloaded-virtual"
+#endif
+
 namespace gz
 {
   namespace rendering
@@ -406,4 +414,9 @@ namespace gz
     }
   }
 }
+
+#if defined(__GNUC__) || defined(__clang__)
+# pragma GCC diagnostic pop
+#endif
+
 #endif