Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ign-common Image pixelformats #10

Open
osrf-migration opened this issue Oct 4, 2017 · 3 comments
Open

Use ign-common Image pixelformats #10

osrf-migration opened this issue Oct 4, 2017 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@osrf-migration
Copy link

Original report (archived issue) by Nate Koenig (Bitbucket: Nathan Koenig).


PixelFormats are defined both in ignition::common::Image and ignition::rendering::PixelFormats.

For consistency, it would be nice to use the version in ignition common. This will also help ignition::msgs.

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


There is a related issue on ign-msgs:

https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-msgs/issues/10/move-image-pixelformat-here-to-remove (gazebosim/gz-msgs#10)

@osrf-migration
Copy link
Author

Original comment by Ian Chen (Bitbucket: Ian Chen, GitHub: iche033).


I'll port the changes back to common and remove these classes in ign-rendering

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • Edited issue description

@osrf-migration osrf-migration added major bug Something isn't working labels Apr 15, 2020
@chapulina chapulina removed the major label May 25, 2020
@chapulina chapulina added the help wanted Extra attention is needed label Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants