Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider merging pure virtual class interfaces with base implementation #22

Open
osrf-migration opened this issue Jan 13, 2018 · 2 comments
Labels

Comments

@osrf-migration
Copy link

Original report (archived issue) by Ian Chen (Bitbucket: Ian Chen, GitHub: iche033).


Instead of having pure virtual interfaces in include/ignition/rendering, we can merge the Base* implementations from include/ignition/rendering/base/ in to src.

It's a trade off between cleaner separation of code and improving code maintainability and extensibility:

Main advantages:

  • reduces the number of files to maintain
  • easier to add/update/remove features or functions in classes

Templated Base classes also them difficult to add private implementations using the pimpl pattern

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • Edited issue description

1 similar comment
@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • Edited issue description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants