[Ogre1.x] Point and spot lights don't cast shadows

[osrf-migration]

Original report (archived issue) by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).

---

Summary

All lights have the Light::SetCastShadow function, but it only works if the light type is directional.

Motivation

I noticed this while reviewing this Ign-Gazebo PR. The issue is analogous to Gazebo issue 2083.

Describe alternatives you've considered

• Implement shadows for all light types
• Print a warning if the function is called for a light that doesn't support shadows

Additional context

This blue spot light had shadows on:

[osrf-migration]

Original comment by Ian Chen (Bitbucket: Ian Chen, GitHub: iche033).

---

• changed title from "Point and spot lights don't cast shadows" to "[Ogre1.x] Point and spot lights don't cast shadows"

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

• Edited issue description

[WilliamLewww]

If the engines are similar enough, I could try to implement point light shadows like how I did here: gazebosim/gazebo-classic#3051.

[chapulina]

That would be nice! ign-rendering uses the same Ogre 1 version as Gazebo classic, so I think that it should be relatively straight-forward to port that implementation.

[iche033]

changes to the core classes should be straight forward to port. The demo world will likely have to live in ign-gazebo because ign-rendering does not support parsing sdf files.

[WilliamLewww]

I'll also see if I can get it working for Ogre2.

[iche033]

directional light and spot light shadows should be working in ogre2. However, there is an issue with having directional light and point light shadows enabled at the same time as found in gazebosim/gz-sim#587 (comment)