Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swappable skybox texture #663

Open
mabelzhang opened this issue Jul 6, 2022 · 0 comments
Open

Add swappable skybox texture #663

mabelzhang opened this issue Jul 6, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mabelzhang
Copy link
Contributor

Desired behavior

Sky box URI can now be changed via sdformat ( gazebosim/sdformat#1037 ), but that field is not being used by gz-rendering yet.

Currently, rendering uses a hardcoded stock sky texture in ogre2/src/media/materials/textures/skybox.dds.

Alternatives considered

Implementation suggestion

Change the code associated with this line:

std::string skyboxEnvMap = "skybox.dds";

which loads the stock texture skybox.dds at https://github.com/gazebosim/gz-rendering/blob/ign-rendering6/ogre2/src/media/materials/textures/skybox.dds

Instead, load a texture from the sky box URI tag.

Additional context

After rendering has been implemented, to add this to gz-sim, start in this line by checking children of <sky> SDF tag:

https://github.com/gazebosim/gz-sim/blob/f39bc25da4a93a0b2ccf5fca8c3e1b6863185a9d/src/gui/plugins/scene3d/Scene3D.cc#L3030

@mabelzhang mabelzhang added enhancement New feature or request help wanted Extra attention is needed labels Jul 6, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Jul 6, 2022
@chapulina chapulina removed this from Inbox in Core development Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant