Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Projector emissive texture #946

Merged
merged 1 commit into from Dec 4, 2023
Merged

Set Projector emissive texture #946

merged 1 commit into from Dec 4, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Nov 30, 2023 •
edited

🦟 Bug fix

Fixes #944

Summary

Set projector emissive texture to be the same as the diffuse texture in ogre 2.x implementation for a more consistent result with the ogre 1.x implementation

Before (projected texture appears darker):
projector_diffuse_only

After (projected texture is now brighter):
projector_emissive

Here's the projector in the harmonic demo world.
Previously I had to use a spot light to illuminate the projected texture because it was too dark. It shouldn't be necessary now with the emissive texture set.

projector_harmonic_demo

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033
Set projector emissive texture
5df32b9 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 30, 2023
@iche033 iche033 changed the base branch from gz-rendering7 to gz-rendering8 November 30, 2023 20:08
@iche033 iche033 added 🎵 harmonic Gazebo Harmonic and removed 🌱 garden Ignition Garden labels Nov 30, 2023
@iche033 iche033 mentioned this pull request Nov 30, 2023
Open
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c42123e) 75.55% compared to head (5df32b9) 75.38%.

Files Patch % Lines
ogre2/src/Ogre2Projector.cc 60.00% 2 Missing ⚠️
Additional details and impacted files 
@@                Coverage Diff                @@
##           gz-rendering8     #946      +/-   ##
=================================================
- Coverage          75.55%   75.38%   -0.17%     
=================================================
  Files                177      177              
  Lines              16882    16965      +83     
=================================================
+ Hits               12755    12789      +34     
- Misses              4127     4176      +49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iche033 iche033 merged commit 303e843 into gz-rendering8 Dec 4, 2023
10 of 14 checks passed
@iche033 iche033 deleted the projector_emissive branch December 4, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
🎵 harmonic Gazebo Harmonic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Other Projector differences between Ogre1 and Ogre2
3 participants
@iche033 @mjcarroll @ahcorde