Avoid configure warning when checking ogre-1.10 #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## ign-rendering3 #411 +/- ##
===============================================
Coverage 53.35% 53.35%
===============================================
Files 131 131
Lines 12036 12036
===============================================
Hits 6422 6422
Misses 5614 5614 Continue to review full report at Codecov.
|
iche033
approved these changes
Sep 15, 2021
Blast545
approved these changes
Sep 16, 2021
Merged
7 tasks
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 Bug fix
Fixes #400
Summary
After #376, the check for Ogre-1.10 is generating warnings during the configuration of the software. The PR changes the behavior to do a fake check with
QUIETto avoid warnings and a real check afterwards if the unofficial ogre version is used.Checklist
Note to maintainers: Remember to use Squash-Merge