Fix point cloud material syntax error #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
ahcorde
approved these changes
Sep 24, 2021
Codecov Report
@@ Coverage Diff @@
## main #433 +/- ##
==========================================
+ Coverage 53.46% 53.49% +0.03%
==========================================
Files 192 192
Lines 19536 19560 +24
==========================================
+ Hits 10444 10464 +20
- Misses 9092 9096 +4
Continue to review full report at Codecov.
|
srmainwaring
pushed a commit
to srmainwaring/gz-rendering
that referenced
this pull request
Oct 21, 2021
Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
WilliamLewww
pushed a commit
to WilliamLewww/ign-rendering
that referenced
this pull request
Dec 7, 2021
Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen ichen@osrfoundation.org
🦟 Bug fix
Summary
Without this fix, you would see an entry in
~/.ignition/rendering/ogre2.log:Point cloud visualization still worked though. It could be just that the initial values are not set correctly.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge