Restore format conversion in Ogre2RenderTarget::Copy #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
This fixes a regression. Now tests pass again Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
Codecov Report
@@ Coverage Diff @@
## ign-rendering6 #564 +/- ##
===============================================
Coverage 54.36% 54.37%
===============================================
Files 198 198
Lines 20151 20146 -5
===============================================
- Hits 10956 10955 -1
+ Misses 9195 9191 -4
Continue to review full report at Codecov.
|
7 tasks
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 Bug fix
No ticket has been associated with this issue
Summary
When ignition moved to Ogre 2.2+;
Ogre2RenderTarget::Copylost the ability to convert between src & dst formats. This PR restores it.It also should be faster because we avoid an unnecessary extra copy.
Additionally,
Ogre2Conversions::ogrePixelFormatshad a missing entry which could trigger bugs if the not-so-popularPF_R8G8B8A8format is usedChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.