Remove unnecessary error message when headless rendering is enabled #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
ahcorde
approved these changes
Feb 28, 2022
Codecov Report
@@ Coverage Diff @@
## ign-rendering6 #569 +/- ##
===============================================
Coverage 54.37% 54.37%
===============================================
Files 198 198
Lines 20146 20149 +3
===============================================
+ Hits 10954 10956 +2
- Misses 9192 9193 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 Bug fix
Fixes gazebosim/gz-sim#1270
Summary
Currently, when running headless mode, an error
[Err] [Ogre2RenderEngine.cc:394] Unable to open display:is emitted inign-gazeboeven though rendering continues to work as expected. I think this is a false alarm and can be removed.Also, currently, when a display is not found in non-headless mode, there is an error emitted saying "Unable to open display". I changed this to a warning since rendering continues to work if headless mode succeeds.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.