Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix render pass example on ogre2 #576

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 5, 2022

Signed-off-by: Ian Chen ichen@osrfoundation.org

🦟 Bug fix

Summary

Running the render_pass example with ogre2 currently results in a crash because it tries to load the distortion render pass which has not been ported to ogre2 implementation yet.

This PR adds a check to make sure the render pass is not null before adding it to the render pass system.

to test, build and run the render_pass example:

./render_pass ogre2

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 5, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Mar 5, 2022
@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #576 (129b247) into ign-rendering6 (dd8b465) will not change coverage.
The diff coverage is n/a.

❗ Current head 129b247 differs from pull request most recent head 2020b0b. Consider uploading reports for the commit 2020b0b to get more accurate results

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering6     #576   +/-   ##
===============================================
  Coverage           54.35%   54.35%           
===============================================
  Files                 198      198           
  Lines               20170    20170           
===============================================
  Hits                10963    10963           
  Misses               9207     9207           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd8b465...2020b0b. Read the comment docs.

Core development automation moved this from Inbox to In review Mar 7, 2022
@ahcorde
Copy link
Contributor

ahcorde commented Mar 7, 2022

@osrf-jenkins retest this please

1 similar comment
@ahcorde
Copy link
Contributor

ahcorde commented Mar 7, 2022

@osrf-jenkins retest this please

@ahcorde ahcorde merged commit bb1b1c2 into ign-rendering6 Mar 7, 2022
@ahcorde ahcorde deleted the fix_render_pass_demo branch March 7, 2022 16:26
Core development automation moved this from In review to Done Mar 7, 2022
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants