Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup depth camera resources on destroy #623

Merged
merged 2 commits into from
May 10, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented May 9, 2022

Signed-off-by: Ian Chen ichen@osrfoundation.org

🦟 Bug fix

Summary

A follow up to #617 - now that we are actually destroying sensors properly, I noticed a crash when running the depth camera integration test in ign-sensors. This should fix the crash (fix is similar to the changes done in #617)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label May 9, 2022
@osrf-triage osrf-triage added this to Inbox in Core development May 9, 2022
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #623 (e9b5e40) into ign-rendering6 (585f4f6) will not change coverage.
The diff coverage is n/a.

❗ Current head e9b5e40 differs from pull request most recent head fe9ebfe. Consider uploading reports for the commit fe9ebfe to get more accurate results

@@               Coverage Diff               @@
##           ign-rendering6     #623   +/-   ##
===============================================
  Coverage           80.00%   80.00%           
===============================================
  Files                   1        1           
  Lines                  15       15           
===============================================
  Hits                   12       12           
  Misses                  3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 585f4f6...fe9ebfe. Read the comment docs.

Core development automation moved this from Inbox to In review May 10, 2022
@iche033 iche033 merged commit bb57d85 into ign-rendering6 May 10, 2022
Core development automation moved this from In review to Done May 10, 2022
@iche033 iche033 deleted the destroy_depth_camera branch May 10, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants