Revert exposing camera intrinsics matrix : https://github.com/gazebosim/gz-rendering/pull/700 #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 581aaab. Signed-off-by: Aditya <aditya050995@gmail.com>
adityapande-1995
force-pushed
the
aditya/revert_PR_700
branch
from
03cba91
to
ba5ddfa
Compare
Codecov Report
@@ Coverage Diff @@
## main #756 +/- ##
==========================================
- Coverage 74.40% 74.38% -0.02%
==========================================
Files 160 160
Lines 14684 14673 -11
==========================================
- Hits 10926 10915 -11
Misses 3758 3758
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
azeey
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
LGTM! windows CI has been failing for a while now https://build.osrfoundation.org/job/ign_rendering-ci-win/test_results_analyzer/, so shouldn't block this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #700, in favour of #755