Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ign to gz in LuxCore demo. #781

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Dec 7, 2022

馃 Bug fix

Summary

Fix luxcore demo by renaming ign to gz and updating its gz library dep versions.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@osrf-triage osrf-triage added this to Inbox in Core development Dec 7, 2022
@github-actions github-actions bot added the 馃尡 garden Ignition Garden label Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #781 (2c578b3) into gz-rendering7 (0937b2a) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           gz-rendering7     #781   +/-   ##
==============================================
  Coverage          75.53%   75.53%           
==============================================
  Files                164      164           
  Lines              14382    14382           
==============================================
  Hits               10864    10864           
  Misses              3518     3518           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Core development automation moved this from Inbox to In review Dec 7, 2022
@ahcorde ahcorde merged commit 05f7e40 into gz-rendering7 Dec 7, 2022
Core development automation moved this from In review to Done Dec 7, 2022
@ahcorde ahcorde deleted the update_luxcore_gz branch December 7, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃尡 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants