Fix transparency over heightmap #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or transparnecy objects Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## ign-rendering6 #811 +/- ##
==================================================
- Coverage 77.76% 77.75% -0.02%
==================================================
Files 146 146
Lines 13418 13429 +11
==================================================
+ Hits 10435 10442 +7
- Misses 2983 2987 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ahcorde
requested changes
Jan 26, 2023
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
ahcorde
requested changes
Jan 27, 2023
ogre2/src/Ogre2Mesh.cc
Outdated
| static_cast<Ogre::HlmsPbsDatablock *>(derived->Datablock())); | ||
| auto datablock = | ||
| static_cast<Ogre::HlmsPbsDatablock *>(derived->Datablock()); | ||
| if (databock) |
There was a problem hiding this comment.
Suggested change
| if (databock) | |
| if (datablock) |
There was a problem hiding this comment.
oops fixed. 3312c33
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
ahcorde
approved these changes
Jan 27, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #789
Summary
Semi-transparent objects were always rendered behind the heightmap as seen in #789. This PR fixes the issue by setting a new render queue for objects with transparency as recommended in https://forums.ogre3d.org/viewtopic.php?t=96950
To test with gazebo:
Select Translate tool and click on any of the models. You should see the RGB axes rendered properly over the heightmap.
Right click on the model -> View > Transparent. The model should also be rendered properly over heightmap
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.