Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom scene viewer tutorial #895

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 1, 2023

🦟 Bug fix

Summary

Following up on #893, this PR removes more references to optix in the custom scene viewer tutorial

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #895 (6a20373) into gz-rendering8 (2901ec2) will not change coverage.
The diff coverage is n/a.

❗ Current head 6a20373 differs from pull request most recent head b2d43dd. Consider uploading reports for the commit b2d43dd to get more accurate results

@@              Coverage Diff               @@
##           gz-rendering8     #895   +/-   ##
==============================================
  Coverage          75.15%   75.15%           
==============================================
  Files                176      176           
  Lines              16851    16851           
==============================================
  Hits               12664    12664           
  Misses              4187     4187           

@ahcorde ahcorde merged commit 077e1e7 into gz-rendering8 Sep 3, 2023
11 of 12 checks passed
@ahcorde ahcorde deleted the update_custom_scene_viewer branch September 3, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants