Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Shaft and Head methods in BaseArrowVisual #94

Merged
merged 4 commits into from
Jun 4, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jun 3, 2020

Complete Shaft and Head methods in BaseArrowVisual

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added enhancement New feature or request 🔮 dome Ignition Dome labels Jun 3, 2020
@ahcorde ahcorde requested a review from iche033 June 3, 2020 15:14
@ahcorde ahcorde self-assigned this Jun 3, 2020
@osrf-triage osrf-triage added this to Inbox in Core development Jun 3, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #94 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #94   +/-   ##
======================================
  Coverage    7.56%   7.56%           
======================================
  Files          26      26           
  Lines        1744    1744           
======================================
  Hits          132     132           
  Misses       1612    1612           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5025487...c4bc61e. Read the comment docs.

Core development automation moved this from Inbox to In review Jun 3, 2020
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Just minor comments

include/ignition/rendering/base/BaseArrowVisual.hh Outdated Show resolved Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from iche033 June 4, 2020 07:53
@iche033 iche033 merged commit ae52975 into master Jun 4, 2020
Core development automation moved this from In review to Done Jun 4, 2020
@iche033 iche033 deleted the ahcorde/enhacement/BaseArrowVisual branch June 4, 2020 19:53
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants