Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repeatedly loading engine when calling sceneFromFirstEngine #961

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jan 19, 2024

🦟 Bug fix

Fixes #959

Summary

Added an better checks to make sure we return the engine if it was already previously loaded instead of loading the engine again.

To test:

gz sim -s -r -v3 --iterations 50 model_photo_shoot.sdf

and the following msg should now be only printed once:

[Msg] Loading plugin [gz-rendering-ogre2]

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested a review from azeey January 19, 2024 21:32
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jan 19, 2024
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these test are failing

  	202 - UNIT_RenderEngineManager_TEST_ogre_gl3plus (SEGFAULT)
  	204 - UNIT_RenderEngineManager_TEST_ogre2_gl3plus (SEGFAULT)
  	206 - UNIT_RenderingIface_TEST_ogre_gl3plus (SEGFAULT)
  	208 - UNIT_RenderingIface_TEST_ogre2_gl3plus (SEGFAULT)

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
Copy link
Contributor Author

iche033 commented Jan 19, 2024

these test are failing

Should be fixed by e297225

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c62f6e9) 75.54% compared to head (e297225) 75.54%.

Additional details and impacted files
@@                Coverage Diff                @@
##           gz-rendering8     #961      +/-   ##
=================================================
- Coverage          75.54%   75.54%   -0.01%     
=================================================
  Files                177      177              
  Lines              16888    16891       +3     
=================================================
+ Hits               12758    12760       +2     
- Misses              4130     4131       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iche033 iche033 merged commit 7116f01 into gz-rendering8 Jan 22, 2024
9 of 11 checks passed
@iche033 iche033 deleted the load_engine branch January 22, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Repeatedly calling rendering::sceneFromFirstRenderEngine loads the engine plugin every time
2 participants