Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip particle passes in Ogre2GpuRays if there are no particles in the scene #973

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 29, 2024

🦟 Bug fix

Summary

Improve Ogre2GpuRays performance in the same way as done in #971 for Ogre2DepthCamera. Added execution mask to skip the particle passes when there are no particles in the scene

The time taken for a lidar (160 degrees FOV and 640 samples) to do a render update is shown below. The speedup is roughly ~1ms (30%). I also included the ogre1.x implementation for comparison. The ogre 1.x implementation is still faster (~5.5x) than the ogre2.x implementation

lidar_camera_particle_profile

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Feb 29, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.62%. Comparing base (4f01a66) to head (70f5003).

Additional details and impacted files
@@                Coverage Diff                @@
##           gz-rendering8     #973      +/-   ##
=================================================
+ Coverage          75.59%   75.62%   +0.02%     
=================================================
  Files                177      177              
  Lines              16934    16952      +18     
=================================================
+ Hits               12802    12820      +18     
  Misses              4132     4132              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iche033 iche033 merged commit 8b92eec into gz-rendering8 Feb 29, 2024
9 of 10 checks passed
@iche033 iche033 deleted the particle_pass_lidar branch February 29, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants