Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add DopplerVelocityLog sensor (#290)" #302

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Dec 9, 2022

This reverts commit 306e92a.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@hidmic hidmic requested a review from caguero December 9, 2022 17:51
@hidmic hidmic requested a review from iche033 as a code owner December 9, 2022 17:51
@osrf-triage osrf-triage added this to Inbox in Core development Dec 9, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Dec 9, 2022
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #302 (92da20f) into gz-sensors7 (2ec0200) will decrease coverage by 2.40%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           gz-sensors7     #302      +/-   ##
===============================================
- Coverage        71.85%   69.45%   -2.41%     
===============================================
  Files               37       35       -2     
  Lines             4690     3778     -912     
===============================================
- Hits              3370     2624     -746     
+ Misses            1320     1154     -166     

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Core development automation moved this from Inbox to In review Dec 9, 2022
This reverts commit 306e92a.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented Dec 9, 2022

DCO fixed.

@hidmic
Copy link
Contributor Author

hidmic commented Dec 12, 2022

@caguero any ideas as to why the ABI checker is failing?

@caguero
Copy link
Contributor

caguero commented Dec 12, 2022

@caguero any ideas as to why the ABI checker is failing?

It could be because some of the symbols aren´t available anymore but that's expected.

@hidmic
Copy link
Contributor Author

hidmic commented Dec 12, 2022

@caguero I see. I'm not allowed to merge until that check passes. Are you? Can we dismiss it?

@iche033 iche033 merged commit ae723cd into gz-sensors7 Dec 12, 2022
Core development automation moved this from In review to Done Dec 12, 2022
@iche033 iche033 deleted the hidmic/revert-290 branch December 12, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants