Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could excess argc/argv be passed to plugins? #110

Open
peci1 opened this issue Sep 2, 2022 · 0 comments
Open

Could excess argc/argv be passed to plugins? #110

peci1 opened this issue Sep 2, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@peci1
Copy link

peci1 commented Sep 2, 2022

Desired behavior

Systems have a way of reading args passed on command line when launching an ign * command.

Alternatives considered

Systems are sad not knowing what the user wanted to tell them.

Implementation suggestion

I don't know exactly how to implement it. There's a few levels of Ruby/C indirection which would all need to be passed, and then there would probably need to be a way to make the arguments available to the systems in Configure().

Additional context

ros-controls/ign_ros_control#3 would benefit from this. Not passing the CLI args further also means that when gz is launched as a ROS node, no remappings or namespaces will be applied to it, as these are specified as CLI args.

Gazebo Classic uses System plugins for parsing the rest of argc/argv. The good thing on the Classic approach is that the programmer explicitly specifies the order in which system plugins will be loaded, so even interactions between several system plugins can be resolved correctly, while being able to rely on a fact that something will be parsed later/earlier.

@peci1 peci1 added the enhancement New feature or request label Sep 2, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Sep 2, 2022
@azeey azeey moved this from Inbox to To do in Core development Oct 17, 2022
@azeey azeey added the help wanted Extra attention is needed label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: To do
Development

No branches or pull requests

2 participants