Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Vertex & Index raw ptrs for efficient reading #474

Merged
merged 4 commits into from Nov 14, 2022

Conversation

darksylinc
Copy link
Contributor

@darksylinc darksylinc commented Oct 30, 2022

馃帀 New feature

Summary

This PR exposes vertex & index raw ptrs.

It is necessary to significantly improve performance of Ogre2RayQuery.

It is up to caller to ensure this unsafe pointers are read properly and hence its usage is discouraged; only when necessary.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Merging #474 (732dc1f) into gz-common5 (431a2ad) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           gz-common5     #474   +/-   ##
===========================================
  Coverage       80.60%   80.61%           
===========================================
  Files              90       90           
  Lines           10237    10241    +4     
===========================================
+ Hits             8252     8256    +4     
  Misses           1985     1985           
Impacted Files Coverage 螖
graphics/src/SubMesh.cc 91.19% <100.00%> (+0.11%) 猬嗭笍

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll moved this from Inbox to In review in Core development Oct 31, 2022
@scpeters
Copy link
Member

I think this could target gz-common5 since this doesn't break API/ABI and that is what gz-rendering8 is still using

@mjcarroll
Copy link
Contributor

@darksylinc I think at this point, if you want to retarget to gz-common5 as @scpeters suggested, we should be good to go here.

@iche033
Copy link
Contributor

iche033 commented Nov 7, 2022

changes look good. Maybe add tests for the new APIs in SubMesh_TEST.cc

@darksylinc darksylinc changed the base branch from main to gz-common5 November 12, 2022 16:56
Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
@darksylinc
Copy link
Contributor Author

  • Rebased and retargeted the PR to gz-common5
  • Added requested unit tests

@darksylinc
Copy link
Contributor Author

darksylinc commented Nov 12, 2022

The submesh test if failing on macOS. Anyone has any idea why?

UPDATE: Nevermind, the info DOES appear.
The detailed info doesn't appear.

Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
@darksylinc
Copy link
Contributor Author

Test fixed. All tests sre green.

@mjcarroll mjcarroll merged commit 7ccc448 into gazebosim:gz-common5 Nov 14, 2022
Core development automation moved this from In review to Done Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants