Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings on Windows #489

Merged
merged 2 commits into from
Nov 8, 2021
Merged

Fix warnings on Windows #489

merged 2 commits into from
Nov 8, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Nov 5, 2021

Signed-off-by: Ian Chen ichen@osrfoundation.org

馃 Bug fix

Summary

This should fix a couple of Windows build warnings found by CI:

'*/' found outside of comment (compiling source file C:\Jenkins\workspace\ign_rendering-pr-win\ws\ign-rendering\ogre\src\OgreCamera.cc)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@osrf-triage osrf-triage added this to Inbox in Core development Nov 5, 2021
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #489 (2a0347c) into main (a49ebcf) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #489   +/-   ##
=======================================
  Coverage   53.48%   53.48%           
=======================================
  Files         198      198           
  Lines       19679    19679           
=======================================
+ Hits        10525    10526    +1     
+ Misses       9154     9153    -1     
Impacted Files Coverage 螖
include/ignition/rendering/base/BaseCamera.hh 65.20% <0.00%> (酶)
...nclude/ignition/rendering/base/BaseRenderTarget.hh 60.22% <0.00%> (酶)
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 100.00% <0.00%> (+3.33%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a49ebcf...2a0347c. Read the comment docs.

@chapulina chapulina moved this from Inbox to In review in Core development Nov 8, 2021
@chapulina chapulina added the Windows Windows support label Nov 8, 2021
@iche033 iche033 merged commit b1d2ac8 into main Nov 8, 2021
@iche033 iche033 deleted the fix_win_warnings branch November 8, 2021 18:51
Core development automation moved this from In review to Done Nov 8, 2021
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants