Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ignition-utils1 #492

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Use ignition-utils1 #492

merged 1 commit into from
Nov 18, 2021

Conversation

scpeters
Copy link
Member

馃帀 New feature

Part of #491.

Summary

Depend on ignition-utils1 so we can use ImplPtr (see #490 (comment) )

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Part of gazebosim#491.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #492 (52ecf23) into main (b1d2ac8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #492   +/-   ##
=======================================
  Coverage   53.48%   53.48%           
=======================================
  Files         198      198           
  Lines       19679    19679           
=======================================
  Hits        10525    10525           
  Misses       9154     9154           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b1d2ac8...52ecf23. Read the comment docs.

Core development automation moved this from Inbox to In review Nov 18, 2021
@scpeters scpeters merged commit a8dcb3a into gazebosim:main Nov 18, 2021
Core development automation moved this from In review to Done Nov 18, 2021
@scpeters scpeters deleted the depend_ign-utils branch November 18, 2021 19:23
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃尡 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants