Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Migration guide #538

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Update Migration guide #538

merged 1 commit into from
Jan 21, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jan 19, 2022

馃帀 New feature

Summary

Update Migration update with info on deprecated function, see https://github.com/ignitionrobotics/ign-rendering/pull/534/files#r781598375

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #538 (47560de) into main (78baf76) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #538   +/-   ##
=======================================
  Coverage   53.39%   53.39%           
=======================================
  Files         211      211           
  Lines       20818    20818           
=======================================
  Hits        11115    11115           
  Misses       9703     9703           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 78baf76...47560de. Read the comment docs.

@github-actions github-actions bot added the 馃尡 garden Ignition Garden label Jan 19, 2022
Core development automation moved this from Inbox to In review Jan 19, 2022
@iche033 iche033 merged commit 76d2b6a into main Jan 21, 2022
@iche033 iche033 deleted the migration_hlms_customization branch January 21, 2022 00:41
Core development automation moved this from In review to Done Jan 21, 2022
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃尡 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants