Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default cameraPassCountPerGpuFlush to 6 #601

Merged

Conversation

darksylinc
Copy link
Contributor

@darksylinc darksylinc commented Apr 4, 2022

馃 Bug fix

No ticket is associated.

But there is a relevant discussion in #323 (comment)

Summary

I thought cameraPassCountPerGpuFlush was already at default 6.

ign-gazebo/src/gui/plugins/scene3d/Scene3D.cc should already be setting this value on the GUI side.

Same goes for ign-gazebo/src/systems/sensors/Sensors.cc

I don't want to think of the implications of setting this value to 6 on already released versions. It's probably harmless. But anyway, the API was introduced in Edifice, Fortress still defaults to legacy; it makes sense for Garden to start defaulting to non-legacy mode.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
@darksylinc darksylinc requested a review from iche033 as a code owner April 4, 2022 00:10
@github-actions github-actions bot added the 馃尡 garden Ignition Garden label Apr 4, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Apr 4, 2022
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #601 (aff851d) into main (8bb21b4) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
+ Coverage   53.55%   53.60%   +0.04%     
==========================================
  Files         214      214              
  Lines       21319    21319              
==========================================
+ Hits        11417    11427      +10     
+ Misses       9902     9892      -10     
Impacted Files Coverage 螖
ogre2/src/Ogre2Scene.cc 78.28% <酶> (+1.48%) 猬嗭笍
include/ignition/rendering/base/BaseCamera.hh 66.05% <0.00%> (+0.36%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 8bb21b4...aff851d. Read the comment docs.

@chapulina chapulina moved this from Inbox to In review in Core development Apr 4, 2022
@iche033 iche033 merged commit 1389f6e into gazebosim:main Apr 4, 2022
Core development automation moved this from In review to Done Apr 4, 2022
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃尡 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants