Default cameraPassCountPerGpuFlush to 6 #601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 Bug fix
No ticket is associated.
But there is a relevant discussion in #323 (comment)
Summary
I thought
cameraPassCountPerGpuFlush
was already at default 6.ign-gazebo/src/gui/plugins/scene3d/Scene3D.cc should already be setting this value on the GUI side.
Same goes for ign-gazebo/src/systems/sensors/Sensors.cc
I don't want to think of the implications of setting this value to 6 on already released versions. It's probably harmless. But anyway, the API was introduced in Edifice, Fortress still defaults to legacy; it makes sense for Garden to start defaulting to non-legacy mode.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.