Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated common::SubMesh::MaterialIndex() with GetMaterialIndex() #606

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

adlarkin
Copy link
Contributor

Signed-off-by: Ashton Larkin 42042756+adlarkin@users.noreply.github.com

🦟 Bug fix

Summary

This PR replaces deprecated calls to ignition::common::SubMesh::MaterialIndex() with the new GetMaterialIndex() method that was introduced in gazebosim/gz-common#319.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

…ndex()

Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 11, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Apr 11, 2022
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #606 (3104889) into main (baf046b) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   53.60%   53.60%   -0.01%     
==========================================
  Files         214      214              
  Lines       21353    21355       +2     
==========================================
+ Hits        11447    11448       +1     
- Misses       9906     9907       +1     
Impacted Files Coverage Δ
ogre/src/OgreMeshFactory.cc 1.03% <0.00%> (-0.01%) ⬇️
ogre2/src/Ogre2MeshFactory.cc 78.98% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baf046b...3104889. Read the comment docs.

@adlarkin adlarkin merged commit 35d87f3 into main Apr 11, 2022
Core development automation moved this from Inbox to Done Apr 11, 2022
@adlarkin adlarkin deleted the adlarkin/remove_deprecated_common_subMeshIdx branch April 11, 2022 19:35
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants