ign -> gz Provisional Finale: Source Migration : gz-rendering #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
ci_matching_branch/finale
branch
from
6b62b23
to
ca9e852
Compare
chapulina
reviewed
Jul 20, 2022
| { | ||
| /// \brief Normal rendering | ||
| IORM_NORMAL, |
There was a problem hiding this comment.
@iche033 , can you confirm if the I here stands for "ignition"?
There was a problem hiding this comment.
I'll assume IORM stands for "Ignition Ogre Rendering Mode"
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
approved these changes
Jul 21, 2022
| { | ||
| /// \brief Normal rendering | ||
| IORM_NORMAL, |
There was a problem hiding this comment.
I'll assume IORM stands for "Ignition Ogre Rendering Mode"
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
ci_matching_branch/finale
branch
from
ff047c9
to
71afb7c
Compare
Codecov Report
@@ Coverage Diff @@
## main #672 +/- ##
=======================================
Coverage 53.59% 53.59%
=======================================
Files 214 214
Lines 21423 21423
=======================================
Hits 11482 11482
Misses 9941 9941
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: gazebo-tooling/release-tools#767