Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Heightmaps tutorial screenshot #716

Merged
merged 4 commits into from
Sep 9, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 9, 2022

🦟 Bug fix

Summary

The current screenshot seems to be from ogre 1.x. When running the tutorial instructions ./heightmaps --dem, it launched the demo with ogre2 so I updated screenshots to match.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 9, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Sep 9, 2022
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #716 (496e4e9) into gz-rendering7 (d3d691e) will not change coverage.
The diff coverage is n/a.

❗ Current head 496e4e9 differs from pull request most recent head 6caefca. Consider uploading reports for the commit 6caefca to get more accurate results

@@              Coverage Diff               @@
##           gz-rendering7     #716   +/-   ##
==============================================
  Coverage          74.14%   74.14%           
==============================================
  Files                164      164           
  Lines              14351    14351           
==============================================
  Hits               10641    10641           
  Misses              3710     3710           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Core development automation moved this from Inbox to In review Sep 9, 2022
@mjcarroll mjcarroll merged commit 0068b40 into gz-rendering7 Sep 9, 2022
Core development automation moved this from In review to Done Sep 9, 2022
@mjcarroll mjcarroll deleted the heightmaps_tutorial_img branch September 9, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants