Camera ShaderSelection: avoid seg-fault #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test currently seg-faults after an EXPECT_* statement is used to check for a nullptr and the pointer is later dereferenced. Wrap the subsequent check in an if statement to allow the rest of the test to continue instead of using ASSERT_*. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
8 tasks
Codecov Report
@@ Coverage Diff @@
## gz-rendering7 #720 +/- ##
==============================================
Coverage 74.14% 74.14%
==============================================
Files 164 164
Lines 14351 14351
==============================================
Hits 10641 10641
Misses 3710 3710 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
test failed again on glados: but at least it gives a clearer indication of the problem than before: |
|
should we re-disable the test on macOS CI? |
+1 to disabling the test for now. |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
iche033
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 Bug fix
Improves error reporting for failing test
Summary
A test was re-enabled for macOS in #703, but it seems to still fail on certain machines (see comments below #703 (comment)).
The test currently seg-faults after an
EXPECT_*statement is used to check for a nullptr and the pointer is later dereferenced. Wrap the subsequent check in an if statement to allow the rest of the test to continue instead of usingASSERT_*. This doesn't fix the underlying issue but it should allow the test to proceed a bit farther and provide more useful failure reporting.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.