Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructured directories #296

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Restructured directories #296

merged 2 commits into from
Sep 14, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Sep 13, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

馃 Bug fix

Summary

I can't release the packages with the current directory structure, because the old ones were already released with this directory structure.

This PR should fix the issue with the bloom process.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Sep 13, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Sep 13, 2022
@methylDragon
Copy link
Contributor

Do the version numbers for the shim packages need to be bumped?

Core development automation moved this from Inbox to In review Sep 13, 2022
@methylDragon
Copy link
Contributor

methylDragon commented Sep 13, 2022

It might be good to leave a note in the README also.

Note: The `ros_ign` prefixed packages are shim packages that redirect to their `ros_gz` counterpart.
Under most circumstances you want to be using the `ros_gz` counterpart.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde merged commit 6cea4c2 into humble Sep 14, 2022
Core development automation moved this from In review to Done Sep 14, 2022
@ahcorde ahcorde deleted the ahcorde/humble/dir_structure branch September 14, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants