Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge between msgs::Pose_V and geometry_msgs/PoseArray msg types #305

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 30, 2022

馃帀 New feature

Summary

Bridges the gz msgs::Pose_V and ros2 geometry_msgs/PoseArray message types

Test it

Updated test. To run:

 colcon test --merge-install --event-handlers console_direct+ --packages-select ros_gz_bridge

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@osrf-triage osrf-triage added this to Inbox in Core development Sep 30, 2022
@iche033 iche033 changed the title Bridge between msgs::Pose_V <-> geometry_msgs/PoseArray msg types Bridge between msgs::Pose_V and geometry_msgs/PoseArray msg types Sep 30, 2022
Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we missing the test in gz_test_msg.cpp?

@ahcorde ahcorde moved this from Inbox to In review in Core development Sep 30, 2022
@iche033
Copy link
Contributor Author

iche033 commented Sep 30, 2022

I think we only need to do that if the gz msg type is new and there are no relevant functions in gz_test_msg to create and compare the msg. In this case, gz_test_msg already has these functions for the Pose_V msg type so I didn't have to add them.

When I ran the test, I see that the new conversions should be covered:

3: [test_ros_subscriber-2] [       OK ] ROSSubscriberTest.pose_v_posearray (11 ms)
4: [test_gz_subscriber-2] [       OK ] GzSubscriberTest.pose_v_posearray (10 ms)

@caguero
Copy link
Contributor

caguero commented Sep 30, 2022

I think we only need to do that if the gz msg type is new and there are no relevant functions in gz_test_msg to create and compare the msg. In this case, gz_test_msg already has these functions for the Pose_V msg type so I didn't have to add them.

When I ran the test, I see that the new conversions should be covered:

3: [test_ros_subscriber-2] [       OK ] ROSSubscriberTest.pose_v_posearray (11 ms)
4: [test_gz_subscriber-2] [       OK ] GzSubscriberTest.pose_v_posearray (10 ms)

Cool, I didn't know that was happening now.

@iche033 iche033 merged commit 1dfcd51 into humble Oct 4, 2022
Core development automation moved this from In review to Done Oct 4, 2022
@iche033 iche033 deleted the iche033/pose_array branch October 4, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants