Bridge between msgs::Float_V and ros_gz_interfaces/Float32Array msg types #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
iche033
changed the title
caguero
reviewed
Sep 30, 2022
| ignition::msgs::Float_V expected_msg; | ||
| createTestMsg(expected_msg); | ||
|
|
||
| EXPECT_FLOAT_EQ(expected_msg.data()[0], _msg->data()[0]); |
There was a problem hiding this comment.
Should we double-check that all values are the same and the sizes are similar? Same in the other compareTestMsg.
There was a problem hiding this comment.
yep, updated test 21f82d1
Signed-off-by: Ian Chen <ichen@openrobotics.org>
caguero
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帀 New feature
Summary
Bridges the gz
msgs::Float_Vand a newros_gz_interfaces/Float32Arraymessage typesAlternatives considered
The initial implementation converts the gz
msgs::Float_Vmsg type to ros2std_msgs/Float32MultiArraymsg type. However, this was discarded because the API doc for Float32MultiArray mentions that the message is deprecated as of Foxy.Test it
Run the integration test:
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.