Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actuator message support in ros_gz_bridge #377

Closed
gragleas opened this issue Mar 27, 2023 · 4 comments
Closed

Actuator message support in ros_gz_bridge #377

gragleas opened this issue Mar 27, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@gragleas
Copy link

Desired behavior

The ability to use ros_gz_bridge parameter bridge for messages of the type gz.msgs.Actuator

Alternatives considered

Send all messages for motor control via gz-transport instead of across ros_gz_bridge via a ros node.

Additional context

It seems as though this was a work in progress some time ago according to this link. It was marked as TODO but the tag has since been removed from the official documentation. It looks like things on the gz side (formerly ignition) had some work done on them at one point, but was removed in #93. I was wondering if there has been any progress on this or if there is a possible workaround.

@gragleas gragleas added the enhancement New feature or request label Mar 27, 2023
@osrf-triage osrf-triage added this to Inbox in Core development Mar 27, 2023
@azeey
Copy link
Contributor

azeey commented Mar 30, 2023

/cc @bperseghetti

@bperseghetti
Copy link
Collaborator

@gragleas we are adding Actuator messages upstream to ros_gz and also have updated multiple plugins AckermannSteering, JointController, and JointPositionController to also listen to an actuator message much like the existing MulticopterMotorModel Plugin. I'll share the links to the PRs when I have them up later today.

@bperseghetti
Copy link
Collaborator

@azeey @gragleas Still need to stop being lazy and actually write the tests for a variety of the ones linked in this: #378

But just so it can be kept track of I included it here.

Also I need to create/join a release group for: https://github.com/rudislabs/actuator_msgs

@azeey azeey moved this from Inbox to In progress in Core development Apr 3, 2023
@azeey
Copy link
Contributor

azeey commented May 26, 2023

Fixed by #378 and #394.

@azeey azeey closed this as completed May 26, 2023
Core development automation moved this from In progress to Done May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants