Fix incorrect subscription on demo #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an incorrect subscription on one of the demos. Running ``` ros2 launch ros_gz_sim_demos gpu_lidar_bridge.launch.py ``` causes rviz2 to crash and exit with the error: ``` rviz2-3] [rviz2-3] >>> [rcutils|error_handling.c:108] rcutils_set_error_state() [rviz2-3] This error state is being overwritten: [rviz2-3] [rviz2-3] 'create_subscription() called for existing topic name rt/lidar with incompatible type sensor_msgs::msg::dds_::PointCloud2_, at ./src/subscription.cpp:146, at ./src/rcl/subscription.c:108' [rviz2-3] [rviz2-3] with this new error message: [rviz2-3] [rviz2-3] 'invalid allocator, at ./src/rcl/subscription.c:218' [rviz2-3] [rviz2-3] rcutils_reset_error() should be called after error handling to avoid this. ``` This is due to an incorrect subscription on the part of the demo. This PR fixes it by getting a subscription to the right topic for the pointcloud display. (`lidar/points` instead of `lidar`). Was tested on garden + humble. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
ahcorde
approved these changes
Jun 6, 2023
|
I'm not sure how forward porting works for |
|
If you have time to cherry-pick this change let me know, Otherwise I will create the PRs |
ahcorde
pushed a commit
that referenced
this pull request
Jun 8, 2023
This PR fixes an incorrect subscription on one of the demos. Running ``` ros2 launch ros_gz_sim_demos gpu_lidar_bridge.launch.py ``` causes rviz2 to crash and exit with the error: ``` rviz2-3] [rviz2-3] >>> [rcutils|error_handling.c:108] rcutils_set_error_state() [rviz2-3] This error state is being overwritten: [rviz2-3] [rviz2-3] 'create_subscription() called for existing topic name rt/lidar with incompatible type sensor_msgs::msg::dds_::PointCloud2_, at ./src/subscription.cpp:146, at ./src/rcl/subscription.c:108' [rviz2-3] [rviz2-3] with this new error message: [rviz2-3] [rviz2-3] 'invalid allocator, at ./src/rcl/subscription.c:218' [rviz2-3] [rviz2-3] rcutils_reset_error() should be called after error handling to avoid this. ``` This is due to an incorrect subscription on the part of the demo. This PR fixes it by getting a subscription to the right topic for the pointcloud display. (`lidar/points` instead of `lidar`). Was tested on garden + humble. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
ahcorde
pushed a commit
that referenced
this pull request
Jun 8, 2023
This PR fixes an incorrect subscription on one of the demos. Running ``` ros2 launch ros_gz_sim_demos gpu_lidar_bridge.launch.py ``` causes rviz2 to crash and exit with the error: ``` rviz2-3] [rviz2-3] >>> [rcutils|error_handling.c:108] rcutils_set_error_state() [rviz2-3] This error state is being overwritten: [rviz2-3] [rviz2-3] 'create_subscription() called for existing topic name rt/lidar with incompatible type sensor_msgs::msg::dds_::PointCloud2_, at ./src/subscription.cpp:146, at ./src/rcl/subscription.c:108' [rviz2-3] [rviz2-3] with this new error message: [rviz2-3] [rviz2-3] 'invalid allocator, at ./src/rcl/subscription.c:218' [rviz2-3] [rviz2-3] rcutils_reset_error() should be called after error handling to avoid this. ``` This is due to an incorrect subscription on the part of the demo. This PR fixes it by getting a subscription to the right topic for the pointcloud display. (`lidar/points` instead of `lidar`). Was tested on garden + humble. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
ahcorde
pushed a commit
that referenced
this pull request
Jun 8, 2023
This PR fixes an incorrect subscription on one of the demos. Running ``` ros2 launch ros_gz_sim_demos gpu_lidar_bridge.launch.py ``` causes rviz2 to crash and exit with the error: ``` rviz2-3] [rviz2-3] >>> [rcutils|error_handling.c:108] rcutils_set_error_state() [rviz2-3] This error state is being overwritten: [rviz2-3] [rviz2-3] 'create_subscription() called for existing topic name rt/lidar with incompatible type sensor_msgs::msg::dds_::PointCloud2_, at ./src/subscription.cpp:146, at ./src/rcl/subscription.c:108' [rviz2-3] [rviz2-3] with this new error message: [rviz2-3] [rviz2-3] 'invalid allocator, at ./src/rcl/subscription.c:218' [rviz2-3] [rviz2-3] rcutils_reset_error() should be called after error handling to avoid this. ``` This is due to an incorrect subscription on the part of the demo. This PR fixes it by getting a subscription to the right topic for the pointcloud display. (`lidar/points` instead of `lidar`). Was tested on garden + humble. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
ahcorde
added a commit
that referenced
this pull request
Jun 8, 2023
This PR fixes an incorrect subscription on one of the demos. Running ``` ros2 launch ros_gz_sim_demos gpu_lidar_bridge.launch.py ``` causes rviz2 to crash and exit with the error: ``` rviz2-3] [rviz2-3] >>> [rcutils|error_handling.c:108] rcutils_set_error_state() [rviz2-3] This error state is being overwritten: [rviz2-3] [rviz2-3] 'create_subscription() called for existing topic name rt/lidar with incompatible type sensor_msgs::msg::dds_::PointCloud2_, at ./src/subscription.cpp:146, at ./src/rcl/subscription.c:108' [rviz2-3] [rviz2-3] with this new error message: [rviz2-3] [rviz2-3] 'invalid allocator, at ./src/rcl/subscription.c:218' [rviz2-3] [rviz2-3] rcutils_reset_error() should be called after error handling to avoid this. ``` This is due to an incorrect subscription on the part of the demo. This PR fixes it by getting a subscription to the right topic for the pointcloud display. (`lidar/points` instead of `lidar`). Was tested on garden + humble. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> Co-authored-by: Arjo Chakravarty <arjoc@intrinsic.ai>
ahcorde
added a commit
that referenced
this pull request
Jun 8, 2023
This PR fixes an incorrect subscription on one of the demos. Running ``` ros2 launch ros_gz_sim_demos gpu_lidar_bridge.launch.py ``` causes rviz2 to crash and exit with the error: ``` rviz2-3] [rviz2-3] >>> [rcutils|error_handling.c:108] rcutils_set_error_state() [rviz2-3] This error state is being overwritten: [rviz2-3] [rviz2-3] 'create_subscription() called for existing topic name rt/lidar with incompatible type sensor_msgs::msg::dds_::PointCloud2_, at ./src/subscription.cpp:146, at ./src/rcl/subscription.c:108' [rviz2-3] [rviz2-3] with this new error message: [rviz2-3] [rviz2-3] 'invalid allocator, at ./src/rcl/subscription.c:218' [rviz2-3] [rviz2-3] rcutils_reset_error() should be called after error handling to avoid this. ``` This is due to an incorrect subscription on the part of the demo. This PR fixes it by getting a subscription to the right topic for the pointcloud display. (`lidar/points` instead of `lidar`). Was tested on garden + humble. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> Co-authored-by: Arjo Chakravarty <arjoc@intrinsic.ai>
ahcorde
added a commit
that referenced
this pull request
Jun 8, 2023
This PR fixes an incorrect subscription on one of the demos. Running ``` ros2 launch ros_gz_sim_demos gpu_lidar_bridge.launch.py ``` causes rviz2 to crash and exit with the error: ``` rviz2-3] [rviz2-3] >>> [rcutils|error_handling.c:108] rcutils_set_error_state() [rviz2-3] This error state is being overwritten: [rviz2-3] [rviz2-3] 'create_subscription() called for existing topic name rt/lidar with incompatible type sensor_msgs::msg::dds_::PointCloud2_, at ./src/subscription.cpp:146, at ./src/rcl/subscription.c:108' [rviz2-3] [rviz2-3] with this new error message: [rviz2-3] [rviz2-3] 'invalid allocator, at ./src/rcl/subscription.c:218' [rviz2-3] [rviz2-3] rcutils_reset_error() should be called after error handling to avoid this. ``` This is due to an incorrect subscription on the part of the demo. This PR fixes it by getting a subscription to the right topic for the pointcloud display. (`lidar/points` instead of `lidar`). Was tested on garden + humble. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> Co-authored-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 Bug fix
Summary
This PR fixes an incorrect subscription on one of the demos. Running
causes rviz2 to crash and exit with the error:
This is due to an incorrect subscription on the part of the demo. This PR fixes it by getting a subscription to the right topic for the pointcloud display. (
lidar/pointsinstead oflidar). Was tested on garden + humble.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻