Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #411

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Update README.md #411

merged 1 commit into from
Jun 12, 2023

Conversation

topguns837
Copy link
Contributor

馃 Bug fix

Summary

Bug : The ROS topic for GPS sensor is not visible in ros2 topic list even though ros-ign bridge has been created for it according to the provided documentation

Fix :

  • The ROS type given for gz.msgs.NavSat is wrong.
  • It should be sensor_msgs/msg/NavSatFix instead of sensor_msgs/msg/NavSatFixed

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻

The ROS type for gz.msgs.NavSat messages should be **sensor_msgs/msg/NavSatFix** instead of **sensor_msgs/msg/NavSatFixed** 



Signed-off-by: Arjun K Haridas <51917087+topguns837@users.noreply.github.com>
Core development automation moved this from Inbox to In review Jun 12, 2023
@ahcorde ahcorde merged commit c279a53 into gazebosim:ros2 Jun 12, 2023
4 checks passed
Core development automation moved this from In review to Done Jun 12, 2023
@ahcorde
Copy link
Collaborator

ahcorde commented Jun 12, 2023

Thank you for the contribution @topguns837 , we need to backport this to iron and humble. Do you have time to do it ? or should I create the PRs ?

@topguns837
Copy link
Contributor Author

sure @ahcorde !
Just to be sure, backport means I have to make the same changes in the humble and iron branch, right ?

@ahcorde
Copy link
Collaborator

ahcorde commented Jun 12, 2023

you should use cherry-pick, here the cmds that you should use:

cd ros_gz
git checkout humble
git checkout -b topguns837/humble/backport_411
git cherry-pick c279a53
git push origin topguns837/humble/backport_411

@topguns837
Copy link
Contributor Author

Would love to contribute, can you assign me this issue ?

@ahcorde
Copy link
Collaborator

ahcorde commented Jun 14, 2023

@topguns837 no need to assign the issue, you can just open the PRs

This was referenced Jun 14, 2023
@topguns837
Copy link
Contributor Author

Hey @ahcorde ,
I have created PR #415 and PR #416 regarding this

@ahcorde
Copy link
Collaborator

ahcorde commented Jun 14, 2023

The backports were not created properly. Can you try again ?

This was referenced Jun 15, 2023
@topguns837
Copy link
Contributor Author

@ahcorde can you check now ?

ahcorde pushed a commit that referenced this pull request Jun 16, 2023
The ROS type for gz.msgs.NavSat messages should be **sensor_msgs/msg/NavSatFix** instead of **sensor_msgs/msg/NavSatFixed**

Signed-off-by: Arjun K Haridas <51917087+topguns837@users.noreply.github.com>
ahcorde pushed a commit that referenced this pull request Jun 16, 2023
The ROS type for gz.msgs.NavSat messages should be **sensor_msgs/msg/NavSatFix** instead of **sensor_msgs/msg/NavSatFixed**

Signed-off-by: Arjun K Haridas <51917087+topguns837@users.noreply.github.com>
ahcorde added a commit that referenced this pull request Jun 21, 2023
ahcorde added a commit that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants