Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SensorNoise msg bridging #417

Merged
merged 3 commits into from
Jun 15, 2023
Merged

SensorNoise msg bridging #417

merged 3 commits into from
Jun 15, 2023

Conversation

adityapande-1995
Copy link
Contributor

@adityapande-1995 adityapande-1995 commented Jun 14, 2023 •
edited
Loading

馃帀 New feature

Summary

This PR adds bridging for SensorNoise msg by adding an equivalent type in ros_gz_interfaces.

Test it

Added the test to ros_gz_bridge test utils, so it should be tested automatically.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻馃敻

@adityapande-1995
Added sensornoise msg
46671f4 
Signed-off-by: Aditya Pande <adityapande@google.com>
@adityapande-1995
Added bridging logic
bbeb775 
Signed-off-by: Aditya Pande <adityapande@google.com>
@adityapande-1995
Added to test utils
1a490f3 
Signed-off-by: Aditya Pande <adityapande@google.com>
@osrf-triage osrf-triage added this to Inbox in Core development Jun 14, 2023
@adityapande-1995 adityapande-1995 mentioned this pull request Jun 14, 2023
Open
Core development automation moved this from Inbox to In review Jun 15, 2023
@ahcorde ahcorde merged commit 979fb12 into ros2 Jun 15, 2023
6 checks passed
Core development automation moved this from In review to Done Jun 15, 2023
@ahcorde ahcorde deleted the aditya/sensor_noise_msg branch June 15, 2023 09:16
ahcorde pushed a commit that referenced this pull request Jun 21, 2023
@adityapande-1995 @ahcorde
SensorNoise msg bridging (#417)
4e7a5f9 
Signed-off-by: Aditya Pande <adityapande@google.com>
ahcorde added a commit that referenced this pull request Jun 21, 2023
@ahcorde @adityapande-1995
[backport iron] SensorNoise msg bridging (#417) (#425)
115aa6b 
Signed-off-by: Alejandro Hern谩ndez Cordero <ahcorde@gmail.com>
Co-authored-by: Aditya Pande <aditya050995@gmail.com>
ahcorde added a commit that referenced this pull request Jun 22, 2023
@ahcorde @adityapande-1995
[backport iron] SensorNoise msg bridging (#417) (#425)
6d12a72 
Signed-off-by: Alejandro Hern谩ndez Cordero <ahcorde@gmail.com>
Co-authored-by: Aditya Pande <aditya050995@gmail.com>
@ahcorde ahcorde mentioned this pull request Jun 22, 2023
Merged
9 tasks
ahcorde added a commit that referenced this pull request Jun 22, 2023
@ahcorde
Merge pull request #427 from gazebosim/ahcorde/humble/backport/417
c09b704 
[backport humble] SensorNoise msg bridging (#417)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Core development
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adityapande-1995 @ahcorde