Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added conversion for Detection3D and Detection3DArray #523

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Added conversion for Detection3D and Detection3DArray #523

merged 2 commits into from
Apr 1, 2024

Conversation

wittenator
Copy link
Contributor

@wittenator wittenator commented Mar 31, 2024 •
edited
Loading

馃帀 New feature

Closes #524

Summary

I added the bridging of Detection3D and Detection3DArray to AnnotatedOriented3DBox and AnnotatedOriented3DBox_V and vice versa.

Test it

WIP

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@wittenator
Added conversion for Detection3D and Detection3DArray
95ff35b 
Signed-off-by: wittenator <9154515+wittenator@users.noreply.github.com>
@wittenator wittenator mentioned this pull request Mar 31, 2024
Closed
ahcorde
ahcorde requested changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor change, otherwise lgtm

ros_gz_bridge/test/utils/gz_test_msg.cpp Show resolved Hide resolved
ros_gz_bridge/test/utils/ros_test_msg.cpp Show resolved Hide resolved
@wittenator
Added includes for size_t datatype
ff6f589 
Signed-off-by: wittenator <9154515+wittenator@users.noreply.github.com>
@wittenator
Copy link
Contributor Author

I added the missing includes now. Thanks for the quick review!

@ahcorde ahcorde merged commit c91acf5 into gazebosim:iron Apr 1, 2024
4 checks passed
ahcorde pushed a commit that referenced this pull request Apr 1, 2024
@wittenator @ahcorde
Added conversion for Detection3D and Detection3DArray (#523)
231b69c 
Signed-off-by: wittenator <9154515+wittenator@users.noreply.github.com>
ahcorde pushed a commit that referenced this pull request Apr 1, 2024
@wittenator @ahcorde
Added conversion for Detection3D and Detection3DArray (#523)
4bac670 
Signed-off-by: wittenator <9154515+wittenator@users.noreply.github.com>
ahcorde added a commit that referenced this pull request Apr 1, 2024
@ahcorde @wittenator
Added conversion for Detection3D and Detection3DArray (#523) (#525)
deccb5b 
Signed-off-by: wittenator <9154515+wittenator@users.noreply.github.com>
Co-authored-by: wittenator <9154515+wittenator@users.noreply.github.com>
ahcorde added a commit that referenced this pull request Apr 2, 2024
@ahcorde @wittenator
Added conversion for Detection3D and Detection3DArray (#523) (#526)
409a941 
Signed-off-by: wittenator <9154515+wittenator@users.noreply.github.com>
Co-authored-by: wittenator <9154515+wittenator@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wittenator @ahcorde