Address reviewer feedback

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
gazebosim · Feb 2, 2022 · 60708f0 · 60708f0
1 parent 74f06b7
commit 60708f0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/src/Model.cc b/src/Model.cc
@@ -84,7 +84,7 @@ class sdf::Model::Implementation
   public: std::vector<std::pair<std::optional<sdf::NestedInclude>,
           sdf::InterfaceModelConstPtr>> interfaceModels;
 
-  /// \brief The interface models specified in this model.
+  /// \brief The interface models added into in this model via merge include.
   public: std::vector<std::pair<std::optional<sdf::NestedInclude>,
           sdf::InterfaceModelConstPtr>> mergedInterfaceModels;
 

diff --git a/test/integration/interface_api.cc b/test/integration/interface_api.cc
@@ -934,8 +934,7 @@ TEST_F(InterfaceAPIMergeInclude, Reposturing)
   std::unordered_map<std::string, std::vector<std::string>> elementsToReposture;
 
   // Create a resposture callback function for a given absolute model name. The
-  // name is used to store poses in `posesAfterReposture` as well as to lookup
-  // interface models in `models`
+  // name is used to store poses in `posesAfterReposture`.
   auto makeRepostureFunc = [&](const std::string &_absoluteName)
   {
     auto repostureFunc =
@@ -1222,12 +1221,12 @@ R"(<include>
 /////////////////////////////////////////////////
 TEST_F(InterfaceAPIMergeInclude, JointModelChild)
 {
-    const std::string testSdf = R"(
+  const std::string testSdf = R"(
   <sdf version="1.9">
     <model name="parent_model">
       <link name="L1"/>
       <include merge="true">
-        <uri>joint_model_parent_or_child.toml</uri>
+        <uri>joint_child_model_frame.toml</uri>
       </include>
       <frame name="frame_1" attached_to="joint_model_child"/>
     </model>

diff --git a/...on/model/joint_model_parent_or_child.toml → ...ration/model/joint_child_model_frame.toml b/...on/model/joint_model_parent_or_child.toml → ...ration/model/joint_child_model_frame.toml
@@ -8,7 +8,7 @@ canonical_link = "base"
 [links.base]
 pose = "0 0 0 0 0 0"
 
-# Test use of __model__ in joint parent or child
+# Test use of __model__ in joint child
 [links.parent_link]
 pose = "0 0 0 0 0 0"