Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

environment_map not declared by material/pbr/specular in material.sdf #639

Closed
FirefoxMetzger opened this issue Jul 28, 2021 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@FirefoxMetzger
Copy link
Contributor

The test sdf material_pbr.sdf uses an element called environment_map inside of the specular element of a pbr material:

https://github.com/ignitionrobotics/sdformat/blob/e4c658f14b73ab839d730c7a402a82a7dfa6a16e/test/sdf/material_pbr.sdf#L36

However, I can not find the matching tag on the website, and it is also missing from the material.sdf.

Website for 1.8: http://sdformat.org/spec?ver=1.8&elem=material#pbr_specular
Website for 1.6 (test uses this version): http://sdformat.org/spec?ver=1.6&elem=material#pbr_specular
Source Code: https://github.com/ignitionrobotics/sdformat/blob/e4c658f14b73ab839d730c7a402a82a7dfa6a16e/sdf/1.8/material.sdf#L112-L153

@jennuine Does the tag falsely declare the element, or is the element missing from the sdf?

@FirefoxMetzger FirefoxMetzger added the bug Something isn't working label Jul 28, 2021
@osrf-triage osrf-triage added this to Inbox in Core development Jul 28, 2021
@jennuine jennuine mentioned this issue Jul 28, 2021
7 tasks
@FirefoxMetzger
Copy link
Contributor Author

FirefoxMetzger commented Jul 29, 2021

The same is true for this element inside the metal element

https://github.com/ignitionrobotics/sdformat/blob/e4c658f14b73ab839d730c7a402a82a7dfa6a16e/test/sdf/material_pbr.sdf#L19

and the same element inside the specular element

https://github.com/ignitionrobotics/sdformat/blob/e4c658f14b73ab839d730c7a402a82a7dfa6a16e/test/sdf/material_pbr.sdf#L39

inside the metal element of the same file. They are not documented in v1.8 or v1.6 (the version of the test file).

@chapulina chapulina moved this from Inbox to In progress in Core development Aug 9, 2021
@jennuine
Copy link
Collaborator

The sdf spec and website have been updated: http://sdformat.org/spec?ver=1.8&elem=material#specular_environment_map

Core development automation moved this from In progress to Done Aug 18, 2021
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants