Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pybind11 tests on windows #1278

Merged
merged 1 commit into from
May 2, 2023

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented May 2, 2023

🦟 Bug fix

Relates to #1276

Summary

Disables pybind11 tests until we find a solution for #1276.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from scpeters as a code owner May 2, 2023 15:27
@azeey azeey self-assigned this May 2, 2023
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels May 2, 2023
@osrf-triage osrf-triage added this to Inbox in Core development May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #1278 (37d6a10) into sdf13 (965d3a4) will increase coverage by 0.05%.
The diff coverage is 99.48%.

❗ Current head 37d6a10 differs from pull request most recent head e4fce4b. Consider uploading reports for the commit e4fce4b to get more accurate results

@@            Coverage Diff             @@
##            sdf13    #1278      +/-   ##
==========================================
+ Coverage   87.66%   87.72%   +0.05%     
==========================================
  Files         126      126              
  Lines       16506    16585      +79     
==========================================
+ Hits        14470    14549      +79     
  Misses       2036     2036              
Impacted Files Coverage Δ
src/Collision.cc 97.43% <92.30%> (+0.17%) ⬆️
src/Box.cc 97.56% <100.00%> (+0.33%) ⬆️
src/Capsule.cc 100.00% <100.00%> (ø)
src/Cylinder.cc 100.00% <100.00%> (ø)
src/Ellipsoid.cc 97.56% <100.00%> (+0.33%) ⬆️
src/Geometry.cc 100.00% <100.00%> (ø)
src/Heightmap.cc 100.00% <100.00%> (ø)
src/Mesh.cc 98.71% <100.00%> (+0.08%) ⬆️
src/Plane.cc 96.36% <100.00%> (+0.36%) ⬆️
src/Polyline.cc 89.55% <100.00%> (+1.02%) ⬆️
... and 2 more

@azeey azeey merged commit 486740e into gazebosim:sdf13 May 2, 2023
6 checks passed
Core development automation moved this from In review to Done May 2, 2023
@azeey azeey deleted the disable_pybind11_tests_win branch May 2, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants