Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy 1.10 spec to 1.11 for sdformat14 #1298

Merged
merged 9 commits into from
Aug 3, 2023

Conversation

jasmeet0915
Copy link
Contributor

@jasmeet0915 jasmeet0915 commented Jun 30, 2023

🎉 New feature

This PR creates a new version of the SDF spec 1.11 targeted for the sdformat14. It would be required by the Automatic Moment of Inertia Calculation project. The SDF proposal for the same can be found here

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Jasmeet Singh <jasmeet0915@gmail.com>
Signed-off-by: Jasmeet Singh <jasmeet0915@gmail.com>
Signed-off-by: Jasmeet Singh <jasmeet0915@gmail.com>
@osrf-triage osrf-triage added this to Inbox in Core development Jun 30, 2023
@quarkytale quarkytale self-requested a review July 2, 2023 23:02
@jasmeet0915 jasmeet0915 marked this pull request as ready for review July 3, 2023 12:10
@scpeters
Copy link
Member

scpeters commented Jul 5, 2023

one failed expectation in Root_TEST.cc that should be easy to fix:

@azeey azeey moved this from Inbox to In review in Core development Jul 10, 2023
Signed-off-by: Jasmeet Singh <jasmeet0915@gmail.com>
@jasmeet0915
Copy link
Contributor Author

@scpeters I have updated the spec version in the failing test in e553e80

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failures are caused by some updates to the spec that have not been included in this PR. Can you merge from main and copy some of the new changes in sdf/1.10 to sdf/1.11?

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #1298 (bbecef0) into main (57511b8) will not change coverage.
The diff coverage is n/a.

❗ Current head bbecef0 differs from pull request most recent head b43f202. Consider uploading reports for the commit b43f202 to get more accurate results

@@           Coverage Diff           @@
##             main    #1298   +/-   ##
=======================================
  Coverage   87.60%   87.60%           
=======================================
  Files         128      128           
  Lines       16830    16830           
=======================================
  Hits        14744    14744           
  Misses       2086     2086           

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Copy link
Collaborator

azeey commented Aug 3, 2023

I found additional differences when I did meld sdf/1.10 sdf/1.11 and added those in b43f202

@azeey azeey merged commit 91876e7 into gazebosim:main Aug 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants