Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Parser warning message when <gazebo> reference does not exist in URDF #1392

Open
wants to merge 5 commits into
base: sdf14
Choose a base branch
from

Conversation

aagrawal05
Copy link

@aagrawal05 aagrawal05 commented Apr 5, 2024

🎉 New feature

Closes #1372

Summary

Added functionality to emit a warning when a reference to a link does not exists by adding a check in the InsertSDFExtensionLink method.

Test it

I've added the ParseGazeboRefDoesntExistWarningMessage test which adds the test case mentioned from #1372 with conflicting U+0069 and U+0456 characters.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Apr 5, 2024
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you check the diff, the indentation in your changes is very wierd. Do you mind to fix it ?

@aagrawal05
Copy link
Author

aagrawal05 commented Apr 5, 2024

If you check the diff, the indentation in your changes is very wierd. Do you mind to fix it ?

Hi, I took a look at it—I think there was something wrong with my text editor, it showed a different output and I hadn't noticed earlier. Let me fix it now.

@aagrawal05
Copy link
Author

aagrawal05 commented Apr 5, 2024

Ok, sorry about the many commits—I think the formatting should be fixed now. I'll make sure everything fits with rigorously with codecheck afterwards.

aagrawal05 and others added 5 commits April 6, 2024 11:27
Signed-off-by: Aditya Agrawal <agraw17107@gapps.uwcsea.edu.sg>
Signed-off-by: Aditya Agrawal <agraw17107@gapps.uwcsea.edu.sg>
Signed-off-by: Aditya Agrawal <58559719+aagrawal05@users.noreply.github.com>
Signed-off-by: Aditya Agrawal <agraw17107@gapps.uwcsea.edu.sg>
Signed-off-by: Aditya Agrawal <58559719+aagrawal05@users.noreply.github.com>
Signed-off-by: Aditya Agrawal <agraw17107@gapps.uwcsea.edu.sg>
Signed-off-by: Aditya Agrawal <58559719+aagrawal05@users.noreply.github.com>
Signed-off-by: Aditya Agrawal <agraw17107@gapps.uwcsea.edu.sg>
@aagrawal05 aagrawal05 requested a review from ahcorde April 8, 2024 12:44
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

URDF to SDF conversion silently ignores <gazebo> tag with non-existing reference
3 participants