-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Parser warning message when <gazebo> reference does not exist in URDF #1392
base: sdf14
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you check the diff, the indentation in your changes is very wierd. Do you mind to fix it ?
22e332a
to
e538eb2
Compare
Hi, I took a look at it—I think there was something wrong with my text editor, it showed a different output and I hadn't noticed earlier. Let me fix it now. |
Ok, sorry about the many commits—I think the formatting should be fixed now. I'll make sure everything fits with rigorously with |
Signed-off-by: Aditya Agrawal <agraw17107@gapps.uwcsea.edu.sg>
Signed-off-by: Aditya Agrawal <agraw17107@gapps.uwcsea.edu.sg>
Signed-off-by: Aditya Agrawal <58559719+aagrawal05@users.noreply.github.com> Signed-off-by: Aditya Agrawal <agraw17107@gapps.uwcsea.edu.sg>
Signed-off-by: Aditya Agrawal <58559719+aagrawal05@users.noreply.github.com> Signed-off-by: Aditya Agrawal <agraw17107@gapps.uwcsea.edu.sg>
Signed-off-by: Aditya Agrawal <58559719+aagrawal05@users.noreply.github.com> Signed-off-by: Aditya Agrawal <agraw17107@gapps.uwcsea.edu.sg>
ab47435
to
2d221fe
Compare
🎉 New feature
Closes #1372
Summary
Added functionality to emit a warning when a reference to a link does not exists by adding a check in the
InsertSDFExtensionLink
method.Test it
I've added the
ParseGazeboRefDoesntExistWarningMessage
test which adds the test case mentioned from #1372 with conflicting U+0069 and U+0456 characters.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.