Remove deprecated Pose(), PoseFrame() functions from sdf10 #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added this to In progress
in SDFormat Development TRI (Moved to https://github.com/orgs/ignitionrobotics/projects/6)
via automation
scpeters
moved this from In progress
to In Review
in SDFormat Development TRI (Moved to https://github.com/orgs/ignitionrobotics/projects/6)
Codecov Report
@@ Coverage Diff @@
## sdf10 #308 +/- ##
==========================================
+ Coverage 86.83% 87.69% +0.86%
==========================================
Files 59 59
Lines 9138 9048 -90
==========================================
Hits 7935 7935
+ Misses 1203 1113 -90
Continue to review full report at Codecov.
|
azeey
approved these changes
Jun 30, 2020
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
SDFormat Development TRI (Moved to https://github.com/orgs/ignitionrobotics/projects/6)
automation
moved this from In Review
to Done
Jun 30, 2020
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Jun 30, 2020
…#308) * Remove all deprecated *PoseFrame() APIs * Remove deprecated Pose(), SetPose() APIs * Migration guide: update per gazebosim#244, gazebosim#276 * Changelog for gazebosim#308. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Jun 30, 2020
…#308) * Remove all deprecated *PoseFrame() APIs * Remove deprecated Pose(), SetPose() APIs * Migration guide: update per gazebosim#244, gazebosim#276 * Changelog for gazebosim#308. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
that referenced
this pull request
Jul 2, 2020
nkoenig
removed this from Done
in SDFormat Development TRI (Moved to https://github.com/orgs/ignitionrobotics/projects/6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several
*Pose()and*PoseFrame()functions were deprecated from DOM objects in libsdformat9 by bitbucket pr 598 and bitbucket pr 599. This removes them and updates the migration guide with the changes from #244 and #276 as well.